From bc183ae002afd1acd1167566cffca17116339cc6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=89=8B=E7=93=9C=E4=B8=80=E5=8D=81=E9=9B=AA?= Date: Fri, 14 Nov 2025 14:53:21 +0800 Subject: [PATCH] Remove unnecessary ts-ignore comments and improve typings Removed redundant // @ts-ignore comments from converter.ts and http-server.ts. Enhanced type safety in event.ts by refining generic parameters for createListenerFunction and createEventFunction. --- packages/napcat-common/src/event.ts | 13 ++++++++----- packages/napcat-core/packet/message/converter.ts | 1 - packages/napcat-onebot/network/http-server.ts | 1 - 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/napcat-common/src/event.ts b/packages/napcat-common/src/event.ts index 22ba5246..49543225 100644 --- a/packages/napcat-common/src/event.ts +++ b/packages/napcat-common/src/event.ts @@ -78,15 +78,18 @@ export class NTEventWrapper { return undefined; } - createListenerFunction (listenerMainName: string, uniqueCode: string = ''): T { + createListenerFunction> (listenerMainName: string, uniqueCode: string = ''): T { const existListener = this.listenerManager.get(listenerMainName + uniqueCode); if (!existListener) { const Listener = this.createProxyDispatch(listenerMainName); const ServiceSubName = /^NodeIKernel(.*?)Listener$/.exec(listenerMainName)![1]; - const Service = `NodeIKernel${ServiceSubName}Service/addKernel${ServiceSubName}Listener`; - - // @ts-ignore - this.createEventFunction(Service)(Listener as T); + const Service = `NodeIKernel${ServiceSubName}Service/addKernel${ServiceSubName}Listener` as `${Listener}/${ListenerMethod}`; + this.createEventFunction< + keyof ServiceNamingMapping, + FuncKeys, + (...args: any[]) => any + >(Service as `${keyof ServiceNamingMapping}/${FuncKeys}`); this.listenerManager.set(listenerMainName + uniqueCode, Listener); return Listener as T; } diff --git a/packages/napcat-core/packet/message/converter.ts b/packages/napcat-core/packet/message/converter.ts index 87c8083a..fcc7a3c1 100644 --- a/packages/napcat-core/packet/message/converter.ts +++ b/packages/napcat-core/packet/message/converter.ts @@ -132,7 +132,6 @@ export class PacketMsgConverter { time: msg.time, msg: msg.msg.map((element) => { if (!this.isValidElementType(element.elementType)) return null; - // @ts-ignore return this.rawToPacketMsgConverters[element.elementType](element as MessageElement); }).filter((e) => e !== null), }; diff --git a/packages/napcat-onebot/network/http-server.ts b/packages/napcat-onebot/network/http-server.ts index 82cb3a4a..9a06e924 100644 --- a/packages/napcat-onebot/network/http-server.ts +++ b/packages/napcat-onebot/network/http-server.ts @@ -72,7 +72,6 @@ export class OB11HttpServerAdapter extends IOB11NetworkAdapter return res.status(400).send('Invalid JSON'); }); }); - // @ts-ignore this.app.use((req, res, next) => this.authorize(this.config.token, req, res, next)); this.app.use(async (req, res) => { await this.handleRequest(req, res);