From 580fd16cebcc1a1089bbc9e6033c555e07cf4125 Mon Sep 17 00:00:00 2001 From: Ink33 Date: Sun, 30 May 2021 23:07:08 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20=E5=90=AF=E7=94=A8linter?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/golint.yml | 24 +++++++++ .github/workflows/suggester.yml | 20 +++++++ .golangci.yml | 94 +++++++++++++++++++++++++++++++++ chat/chat.go | 1 - chat/learn.go | 1 - setutime/pic_searcher.go | 3 +- setutime/setu_geter.go | 3 +- 7 files changed, 142 insertions(+), 4 deletions(-) create mode 100644 .github/workflows/golint.yml create mode 100644 .github/workflows/suggester.yml create mode 100644 .golangci.yml diff --git a/.github/workflows/golint.yml b/.github/workflows/golint.yml new file mode 100644 index 00000000..94eaa98b --- /dev/null +++ b/.github/workflows/golint.yml @@ -0,0 +1,24 @@ +name: Lint + +on: [push] + +jobs: + golangci: + name: lint_golangci-lint + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2.3.4 + + - name: golangci-lint + uses: golangci/golangci-lint-action@v2.5.2 + with: + version: latest + + - name: Commit back + continue-on-error: true + run: | + git config --local user.name 'github-actions[bot]' + git config --local user.email '41898282+github-actions[bot]@users.noreply.github.com' + git add --all + git commit -m "🎨 改进代码样式" + git push diff --git a/.github/workflows/suggester.yml b/.github/workflows/suggester.yml new file mode 100644 index 00000000..022fdf2e --- /dev/null +++ b/.github/workflows/suggester.yml @@ -0,0 +1,20 @@ +name: Suggester + +on: [pull_request] + +jobs: + golangci: + name: lint + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2.3.4 + + - name: golangci-lint + uses: golangci/golangci-lint-action@v2.5.2 + with: + version: latest + + - name: Suggester + uses: reviewdog/action-suggester@v1.0.1 + with: + tool_name: golangci-lint \ No newline at end of file diff --git a/.golangci.yml b/.golangci.yml new file mode 100644 index 00000000..c26e2510 --- /dev/null +++ b/.golangci.yml @@ -0,0 +1,94 @@ +linters-settings: + errcheck: + ignore: fmt:.*,io/ioutil:^Read.* + ignoretests: true + + goimports: + local-prefixes: github.com/Yiwen-Chan/ZeroBot-Plugin + + gocritic: + disabled-checks: + - exitAfterDefer + + forbidigo: + # Forbid the following identifiers + forbid: + - ^fmt\.Errorf$ # consider errors.Errorf in github.com/pkg/errors + +linters: + # please, do not use `enable-all`: it's deprecated and will be removed soon. + # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint + fast: true + enable: + - bodyclose + - deadcode + - depguard + - dogsled + - dupl + - errcheck + - exportloopref + - exhaustive + #- funlen + #- goconst + - gocritic + #- gocyclo + - gofmt + - goimports + - goprintffuncname + #- gosec + - gosimple + - govet + - ineffassign + - misspell + - nolintlint + - rowserrcheck + - staticcheck + - structcheck + - stylecheck + - typecheck + - unconvert + - unparam + - unused + - varcheck + - whitespace + - prealloc + - predeclared + - asciicheck + - forbidigo + - makezero + - revive + #- interfacer + + # don't enable: + # - scopelint + # - gochecknoglobals + # - gocognit + # - godot + # - godox + # - goerr113 + # - interfacer + # - maligned + # - nestif + # - testpackage + # - wsl + +run: + # default concurrency is a available CPU number. + # concurrency: 4 # explicitly omit this value to fully utilize available resources. + deadline: 5m + issues-exit-code: 1 + tests: false + +# output configuration options +output: + format: "colored-line-number" + print-issued-lines: true + print-linter-name: true + uniq-by-line: true + +issues: + # Fix found issues (if it's supported by the linter) + fix: true + exclude-use-default: false + exclude: + - "Error return value of .((os.)?std(out|err)..*|.*Close|.*Flush|os.Remove(All)?|.*print(f|ln)?|os.(Un)?Setenv). is not check" diff --git a/chat/chat.go b/chat/chat.go index 1666fe11..2ea78a5a 100644 --- a/chat/chat.go +++ b/chat/chat.go @@ -79,7 +79,6 @@ func init() { // 插件主体 )) return } - }) zero.OnFullMatch(`群温度`).SetBlock(true).FirstPriority(). Handle(func(ctx *zero.Ctx) { diff --git a/chat/learn.go b/chat/learn.go index 7bd5ba9b..388d1d46 100644 --- a/chat/learn.go +++ b/chat/learn.go @@ -175,7 +175,6 @@ func init() { return } }) - } func botPath() string { diff --git a/setutime/pic_searcher.go b/setutime/pic_searcher.go index 3309b35b..5b9a6840 100644 --- a/setutime/pic_searcher.go +++ b/setutime/pic_searcher.go @@ -6,9 +6,10 @@ import ( "strings" "time" - utils "github.com/Yiwen-Chan/ZeroBot-Plugin/setutime/utils" zero "github.com/wdvxdr1123/ZeroBot" "github.com/wdvxdr1123/ZeroBot/message" + + utils "github.com/Yiwen-Chan/ZeroBot-Plugin/setutime/utils" ) func init() { // 插件主体 diff --git a/setutime/setu_geter.go b/setutime/setu_geter.go index 0084b3d0..c8e4f0d5 100644 --- a/setutime/setu_geter.go +++ b/setutime/setu_geter.go @@ -6,9 +6,10 @@ import ( "strings" "time" - "github.com/Yiwen-Chan/ZeroBot-Plugin/setutime/utils" zero "github.com/wdvxdr1123/ZeroBot" "github.com/wdvxdr1123/ZeroBot/extension/rate" + + "github.com/Yiwen-Chan/ZeroBot-Plugin/setutime/utils" ) var limit = rate.NewManager(time.Minute*1, 5)