From 0001bc60a90e22d9d4ea3b472254308e5edf4c4b Mon Sep 17 00:00:00 2001
From: fullex <106392080+0xfullex@users.noreply.github.com>
Date: Wed, 25 Jun 2025 19:59:47 +0800
Subject: [PATCH] refactor: rename isWindows to isWin for consistency across
 main/renderer (#7530)

refactor: rename isWindows to isWin for consistency across components
---
 .../src/components/MinApp/MinappPopupContainer.tsx     |  6 +++---
 src/renderer/src/components/app/Navbar.tsx             |  6 +++---
 src/renderer/src/config/constant.ts                    |  2 +-
 src/renderer/src/hooks/useFullScreenNotice.ts          |  4 ++--
 src/renderer/src/hooks/useShortcuts.ts                 |  4 ++--
 .../pages/settings/MCPSettings/McpSettingsNavbar.tsx   |  4 ++--
 .../SelectionAssistantSettings.tsx                     | 10 +++++-----
 src/renderer/src/pages/settings/ShortcutSettings.tsx   |  6 +++---
 src/renderer/src/utils/export.ts                       |  4 ++--
 src/renderer/src/utils/input.ts                        |  4 ++--
 10 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/src/renderer/src/components/MinApp/MinappPopupContainer.tsx b/src/renderer/src/components/MinApp/MinappPopupContainer.tsx
index bd360c8a30..f9a4ee7e1e 100644
--- a/src/renderer/src/components/MinApp/MinappPopupContainer.tsx
+++ b/src/renderer/src/components/MinApp/MinappPopupContainer.tsx
@@ -10,7 +10,7 @@ import {
   PushpinOutlined,
   ReloadOutlined
 } from '@ant-design/icons'
-import { isLinux, isMac, isWindows } from '@renderer/config/constant'
+import { isLinux, isMac, isWin } from '@renderer/config/constant'
 import { DEFAULT_MIN_APPS } from '@renderer/config/minapps'
 import { useBridge } from '@renderer/hooks/useBridge'
 import { useMinappPopup } from '@renderer/hooks/useMinappPopup'
@@ -303,7 +303,7 @@ const MinappPopupContainer: React.FC = () => {
           </Tooltip>
         )}
         <Spacer />
-        <ButtonsGroup className={isWindows || isLinux ? 'windows' : ''}>
+        <ButtonsGroup className={isWin || isLinux ? 'windows' : ''}>
           <Tooltip title={t('minapp.popup.goBack')} mouseEnterDelay={0.8} placement="bottom">
             <Button onClick={() => handleGoBack(appInfo.id)}>
               <ArrowLeftOutlined />
@@ -452,7 +452,7 @@ const ButtonsGroup = styled.div`
   gap: 5px;
   -webkit-app-region: no-drag;
   &.windows {
-    margin-right: ${isWindows ? '130px' : isLinux ? '100px' : 0};
+    margin-right: ${isWin ? '130px' : isLinux ? '100px' : 0};
     background-color: var(--color-background-mute);
     border-radius: 50px;
     padding: 0 3px;
diff --git a/src/renderer/src/components/app/Navbar.tsx b/src/renderer/src/components/app/Navbar.tsx
index e6176c2a00..9514f200b8 100644
--- a/src/renderer/src/components/app/Navbar.tsx
+++ b/src/renderer/src/components/app/Navbar.tsx
@@ -1,4 +1,4 @@
-import { isLinux, isMac, isWindows } from '@renderer/config/constant'
+import { isLinux, isMac, isWin } from '@renderer/config/constant'
 import { useFullscreen } from '@renderer/hooks/useFullscreen'
 import useNavBackgroundColor from '@renderer/hooks/useNavBackgroundColor'
 import type { FC, PropsWithChildren } from 'react'
@@ -78,7 +78,7 @@ const NavbarRightContainer = styled.div<{ $isFullscreen: boolean }>`
   display: flex;
   align-items: center;
   padding: 0 12px;
-  padding-right: ${({ $isFullscreen }) => ($isFullscreen ? '12px' : isWindows ? '140px' : isLinux ? '120px' : '12px')};
+  padding-right: ${({ $isFullscreen }) => ($isFullscreen ? '12px' : isWin ? '140px' : isLinux ? '120px' : '12px')};
   justify-content: flex-end;
 `
 
@@ -91,5 +91,5 @@ const NavbarMainContainer = styled.div<{ $isFullscreen: boolean }>`
   padding: 0 ${isMac ? '20px' : 0};
   font-weight: bold;
   color: var(--color-text-1);
-  padding-right: ${({ $isFullscreen }) => ($isFullscreen ? '12px' : isWindows ? '140px' : isLinux ? '120px' : '12px')};
+  padding-right: ${({ $isFullscreen }) => ($isFullscreen ? '12px' : isWin ? '140px' : isLinux ? '120px' : '12px')};
 `
diff --git a/src/renderer/src/config/constant.ts b/src/renderer/src/config/constant.ts
index 05f9bfbc19..5a50daa9d1 100644
--- a/src/renderer/src/config/constant.ts
+++ b/src/renderer/src/config/constant.ts
@@ -6,7 +6,7 @@ export const DEFAULT_KNOWLEDGE_THRESHOLD = 0.0
 
 export const platform = window.electron?.process?.platform
 export const isMac = platform === 'darwin'
-export const isWindows = platform === 'win32' || platform === 'win64'
+export const isWin = platform === 'win32' || platform === 'win64'
 export const isLinux = platform === 'linux'
 
 export const SILICON_CLIENT_ID = 'SFaJLLq0y6CAMoyDm81aMu'
diff --git a/src/renderer/src/hooks/useFullScreenNotice.ts b/src/renderer/src/hooks/useFullScreenNotice.ts
index 9f95ddd9c7..69af2da4be 100644
--- a/src/renderer/src/hooks/useFullScreenNotice.ts
+++ b/src/renderer/src/hooks/useFullScreenNotice.ts
@@ -1,4 +1,4 @@
-import { isWindows } from '@renderer/config/constant'
+import { isWin } from '@renderer/config/constant'
 import { IpcChannel } from '@shared/IpcChannel'
 import { useEffect } from 'react'
 import { useTranslation } from 'react-i18next'
@@ -8,7 +8,7 @@ export function useFullScreenNotice() {
 
   useEffect(() => {
     const cleanup = window.electron.ipcRenderer.on(IpcChannel.FullscreenStatusChanged, (_, isFullscreen) => {
-      if (isWindows && isFullscreen) {
+      if (isWin && isFullscreen) {
         window.message.info({
           content: t('common.fullscreen'),
           duration: 3,
diff --git a/src/renderer/src/hooks/useShortcuts.ts b/src/renderer/src/hooks/useShortcuts.ts
index 691bd42f97..a809eee09e 100644
--- a/src/renderer/src/hooks/useShortcuts.ts
+++ b/src/renderer/src/hooks/useShortcuts.ts
@@ -1,4 +1,4 @@
-import { isMac, isWindows } from '@renderer/config/constant'
+import { isMac, isWin } from '@renderer/config/constant'
 import { useAppSelector } from '@renderer/store'
 import { orderBy } from 'lodash'
 import { useCallback } from 'react'
@@ -72,7 +72,7 @@ export function useShortcutDisplay(key: string) {
           case 'ctrl':
             return isMac ? '⌃' : 'Ctrl'
           case 'command':
-            return isMac ? '⌘' : isWindows ? 'Win' : 'Super'
+            return isMac ? '⌘' : isWin ? 'Win' : 'Super'
           case 'alt':
             return isMac ? '⌥' : 'Alt'
           case 'shift':
diff --git a/src/renderer/src/pages/settings/MCPSettings/McpSettingsNavbar.tsx b/src/renderer/src/pages/settings/MCPSettings/McpSettingsNavbar.tsx
index 7986ea5766..cef0625785 100644
--- a/src/renderer/src/pages/settings/MCPSettings/McpSettingsNavbar.tsx
+++ b/src/renderer/src/pages/settings/MCPSettings/McpSettingsNavbar.tsx
@@ -1,6 +1,6 @@
 import { NavbarRight } from '@renderer/components/app/Navbar'
 import { HStack } from '@renderer/components/Layout'
-import { isLinux, isWindows } from '@renderer/config/constant'
+import { isLinux, isWin } from '@renderer/config/constant'
 import { useFullscreen } from '@renderer/hooks/useFullscreen'
 import { Button, Dropdown, Menu, type MenuProps } from 'antd'
 import { ChevronDown, Search } from 'lucide-react'
@@ -74,7 +74,7 @@ export const McpSettingsNavbar = () => {
   }))
 
   return (
-    <NavbarRight style={{ paddingRight: useFullscreen() ? '12px' : isWindows ? 150 : isLinux ? 120 : 12 }}>
+    <NavbarRight style={{ paddingRight: useFullscreen() ? '12px' : isWin ? 150 : isLinux ? 120 : 12 }}>
       <HStack alignItems="center" gap={5}>
         <Button
           size="small"
diff --git a/src/renderer/src/pages/settings/SelectionAssistantSettings/SelectionAssistantSettings.tsx b/src/renderer/src/pages/settings/SelectionAssistantSettings/SelectionAssistantSettings.tsx
index 4947b00336..c10ecd617b 100644
--- a/src/renderer/src/pages/settings/SelectionAssistantSettings/SelectionAssistantSettings.tsx
+++ b/src/renderer/src/pages/settings/SelectionAssistantSettings/SelectionAssistantSettings.tsx
@@ -1,4 +1,4 @@
-import { isWindows } from '@renderer/config/constant'
+import { isWin } from '@renderer/config/constant'
 import { useTheme } from '@renderer/context/ThemeProvider'
 import { useSelectionAssistant } from '@renderer/hooks/useSelectionAssistant'
 import { FilterMode, TriggerMode } from '@renderer/types/selectionTypes'
@@ -53,7 +53,7 @@ const SelectionAssistantSettings: FC = () => {
 
   // force disable selection assistant on non-windows systems
   useEffect(() => {
-    if (!isWindows && selectionEnabled) {
+    if (!isWin && selectionEnabled) {
       setSelectionEnabled(false)
     }
   }, [selectionEnabled, setSelectionEnabled])
@@ -76,12 +76,12 @@ const SelectionAssistantSettings: FC = () => {
         <SettingRow>
           <SettingLabel>
             <SettingRowTitle>{t('selection.settings.enable.title')}</SettingRowTitle>
-            {!isWindows && <SettingDescription>{t('selection.settings.enable.description')}</SettingDescription>}
+            {!isWin && <SettingDescription>{t('selection.settings.enable.description')}</SettingDescription>}
           </SettingLabel>
           <Switch
-            checked={isWindows && selectionEnabled}
+            checked={isWin && selectionEnabled}
             onChange={(checked) => setSelectionEnabled(checked)}
-            disabled={!isWindows}
+            disabled={!isWin}
           />
         </SettingRow>
 
diff --git a/src/renderer/src/pages/settings/ShortcutSettings.tsx b/src/renderer/src/pages/settings/ShortcutSettings.tsx
index a414dd2212..9c8eec0653 100644
--- a/src/renderer/src/pages/settings/ShortcutSettings.tsx
+++ b/src/renderer/src/pages/settings/ShortcutSettings.tsx
@@ -1,6 +1,6 @@
 import { ClearOutlined, UndoOutlined } from '@ant-design/icons'
 import { HStack } from '@renderer/components/Layout'
-import { isMac, isWindows } from '@renderer/config/constant'
+import { isMac, isWin } from '@renderer/config/constant'
 import { useTheme } from '@renderer/context/ThemeProvider'
 import { useShortcuts } from '@renderer/hooks/useShortcuts'
 import { useAppDispatch } from '@renderer/store'
@@ -24,7 +24,7 @@ const ShortcutSettings: FC = () => {
 
   //if shortcut is not available on all the platforms, block the shortcut here
   let shortcuts = originalShortcuts
-  if (!isWindows) {
+  if (!isWin) {
     //Selection Assistant only available on Windows now
     const excludedShortcuts = ['selection_assistant_toggle', 'selection_assistant_select_text']
     shortcuts = shortcuts.filter((s) => !excludedShortcuts.includes(s.key))
@@ -86,7 +86,7 @@ const ShortcutSettings: FC = () => {
           case 'Ctrl':
             return isMac ? '⌃' : 'Ctrl'
           case 'Command':
-            return isMac ? '⌘' : isWindows ? 'Win' : 'Super'
+            return isMac ? '⌘' : isWin ? 'Win' : 'Super'
           case 'Alt':
             return isMac ? '⌥' : 'Alt'
           case 'Shift':
diff --git a/src/renderer/src/utils/export.ts b/src/renderer/src/utils/export.ts
index 373ad08dc7..6c0004d90b 100644
--- a/src/renderer/src/utils/export.ts
+++ b/src/renderer/src/utils/export.ts
@@ -546,13 +546,13 @@ export const exportMarkdownToObsidian = async (attributes: any) => {
  */
 function transformObsidianFileName(fileName: string): string {
   const platform = window.navigator.userAgent
-  const isWindows = /win/i.test(platform)
+  const isWin = /win/i.test(platform)
   const isMac = /mac/i.test(platform)
 
   // 删除Obsidian 全平台无效字符
   let sanitized = fileName.replace(/[#|\\^\\[\]]/g, '')
 
-  if (isWindows) {
+  if (isWin) {
     // Windows 的清理
     sanitized = sanitized
       .replace(/[<>:"\\/\\|?*]/g, '') // 移除无效字符
diff --git a/src/renderer/src/utils/input.ts b/src/renderer/src/utils/input.ts
index 649941072d..3f1f337190 100644
--- a/src/renderer/src/utils/input.ts
+++ b/src/renderer/src/utils/input.ts
@@ -1,4 +1,4 @@
-import { isMac, isWindows } from '@renderer/config/constant'
+import { isMac, isWin } from '@renderer/config/constant'
 import Logger from '@renderer/config/logger'
 import type { SendMessageShortcut } from '@renderer/store/settings'
 import { FileType } from '@renderer/types'
@@ -71,7 +71,7 @@ export const getSendMessageShortcutLabel = (shortcut: SendMessageShortcut) => {
     case 'Alt+Enter':
       return `${isMac ? '⌥' : 'Alt'} + Enter`
     case 'Command+Enter':
-      return `${isMac ? '⌘' : isWindows ? 'Win' : 'Super'} + Enter`
+      return `${isMac ? '⌘' : isWin ? 'Win' : 'Super'} + Enter`
     case 'Shift+Enter':
       return 'Shift + Enter'
     default: