From 2a98da5cc50c9204722ed93248a04c4d68374d7b Mon Sep 17 00:00:00 2001 From: kangfenmao Date: Wed, 28 May 2025 16:24:47 +0800 Subject: [PATCH] fix: suppress exhaustive-deps warnings in multiple components - Added eslint-disable comments for react-hooks/exhaustive-deps in CustomCollapse, DmxapiPage, SelectionActionApp, ActionGeneral, and ActionTranslate components to prevent warnings related to missing dependencies in useEffect hooks. --- src/renderer/src/components/CustomCollapse.tsx | 1 + src/renderer/src/pages/paintings/DmxapiPage.tsx | 1 + src/renderer/src/windows/selection/action/SelectionActionApp.tsx | 1 + .../src/windows/selection/action/components/ActionGeneral.tsx | 1 + .../src/windows/selection/action/components/ActionTranslate.tsx | 1 + 5 files changed, 5 insertions(+) diff --git a/src/renderer/src/components/CustomCollapse.tsx b/src/renderer/src/components/CustomCollapse.tsx index 062af0a7ec..9c94084d70 100644 --- a/src/renderer/src/components/CustomCollapse.tsx +++ b/src/renderer/src/components/CustomCollapse.tsx @@ -66,6 +66,7 @@ const CustomCollapse: FC = ({ const collapseStyle = merge({}, defaultCollapseStyle, style) const collapseItemStyles = useMemo(() => { return merge({}, defaultCollapseItemStyles, styles) + // eslint-disable-next-line react-hooks/exhaustive-deps }, [activeKeys]) return ( diff --git a/src/renderer/src/pages/paintings/DmxapiPage.tsx b/src/renderer/src/pages/paintings/DmxapiPage.tsx index b371ac10e7..c3cbc0f93f 100644 --- a/src/renderer/src/pages/paintings/DmxapiPage.tsx +++ b/src/renderer/src/pages/paintings/DmxapiPage.tsx @@ -348,6 +348,7 @@ const DmxapiPage: FC<{ Options: string[] }> = ({ Options }) => { return () => { if (spaceClickTimer.current) { + // eslint-disable-next-line react-hooks/exhaustive-deps clearTimeout(spaceClickTimer.current) } } diff --git a/src/renderer/src/windows/selection/action/SelectionActionApp.tsx b/src/renderer/src/windows/selection/action/SelectionActionApp.tsx index 58a7269b7a..b29d16c194 100644 --- a/src/renderer/src/windows/selection/action/SelectionActionApp.tsx +++ b/src/renderer/src/windows/selection/action/SelectionActionApp.tsx @@ -55,6 +55,7 @@ const SelectionActionApp: FC = () => { window.removeEventListener('blur', handleWindowBlur) } // don't need any dependencies + // eslint-disable-next-line react-hooks/exhaustive-deps }, []) useEffect(() => { diff --git a/src/renderer/src/windows/selection/action/components/ActionGeneral.tsx b/src/renderer/src/windows/selection/action/components/ActionGeneral.tsx index 31934a12b2..a481b55eb8 100644 --- a/src/renderer/src/windows/selection/action/components/ActionGeneral.tsx +++ b/src/renderer/src/windows/selection/action/components/ActionGeneral.tsx @@ -197,6 +197,7 @@ const ActionGeneral: FC = React.memo(({ action, scrollToBottom }) => { setError(err instanceof Error ? err.message : 'An error occurred') console.error('Error fetching result:', err) } + // eslint-disable-next-line react-hooks/exhaustive-deps }, []) useEffect(() => { diff --git a/src/renderer/src/windows/selection/action/components/ActionTranslate.tsx b/src/renderer/src/windows/selection/action/components/ActionTranslate.tsx index 76999e1cc0..e826495dd8 100644 --- a/src/renderer/src/windows/selection/action/components/ActionTranslate.tsx +++ b/src/renderer/src/windows/selection/action/components/ActionTranslate.tsx @@ -76,6 +76,7 @@ const ActionTranslate: FC = ({ action, scrollToBottom }) => { } finally { translatingRef.current = false } + // eslint-disable-next-line react-hooks/exhaustive-deps }, [action, targetLanguage, translateModel]) useEffect(() => {