From 36ef2e981a9e1fd4fba9156e1ae792ee975740ec Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 11 Dec 2025 08:29:49 +0000
Subject: [PATCH] fix: add Number() conversion to legacy BaseApiClient methods

Co-authored-by: DeJeune <67425183+DeJeune@users.noreply.github.com>
---
 src/renderer/src/aiCore/legacy/clients/BaseApiClient.ts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/renderer/src/aiCore/legacy/clients/BaseApiClient.ts b/src/renderer/src/aiCore/legacy/clients/BaseApiClient.ts
index 5d435b907..69b0173a7 100644
--- a/src/renderer/src/aiCore/legacy/clients/BaseApiClient.ts
+++ b/src/renderer/src/aiCore/legacy/clients/BaseApiClient.ts
@@ -205,7 +205,9 @@ export abstract class BaseApiClient<
       return undefined
     }
     const assistantSettings = getAssistantSettings(assistant)
-    return assistantSettings?.enableTemperature ? assistantSettings?.temperature : undefined
+    const temperature = assistantSettings?.temperature
+    // Ensure temperature is always returned as a number (not a string)
+    return assistantSettings?.enableTemperature && temperature !== undefined ? Number(temperature) : undefined
   }
 
   public getTopP(assistant: Assistant, model: Model): number | undefined {
@@ -213,7 +215,9 @@ export abstract class BaseApiClient<
       return undefined
     }
     const assistantSettings = getAssistantSettings(assistant)
-    return assistantSettings?.enableTopP ? assistantSettings?.topP : undefined
+    const topP = assistantSettings?.topP
+    // Ensure topP is always returned as a number (not a string)
+    return assistantSettings?.enableTopP && topP !== undefined ? Number(topP) : undefined
   }
 
   // NOTE: 这个也许可以迁移到OpenAIBaseClient