From 52e2aff0054c6c49b881d2741611627f45cc26fc Mon Sep 17 00:00:00 2001 From: icarus Date: Mon, 20 Oct 2025 19:46:57 +0800 Subject: [PATCH] fix(ocr): add missing error message for unavailable provider Add "not_availabel" translation key and use it when provider is unavailable. Also update type name from ImageOcrProvider to OcrProvider to better reflect its usage. --- src/renderer/src/hooks/ocr/useOcr.ts | 6 +++--- src/renderer/src/i18n/locales/en-us.json | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/renderer/src/hooks/ocr/useOcr.ts b/src/renderer/src/hooks/ocr/useOcr.ts index 5534839e9b..02cc99bdcb 100644 --- a/src/renderer/src/hooks/ocr/useOcr.ts +++ b/src/renderer/src/hooks/ocr/useOcr.ts @@ -1,6 +1,6 @@ import { loggerService } from '@logger' import * as OcrService from '@renderer/services/ocr/OcrService' -import type { ImageFileMetadata, ImageOcrProvider, SupportedOcrFile } from '@renderer/types' +import type { ImageFileMetadata, OcrProvider, SupportedOcrFile } from '@renderer/types' import { isImageFileMetadata } from '@renderer/types' import { formatErrorMessage } from '@renderer/utils/error' import { useCallback } from 'react' @@ -10,7 +10,7 @@ import { useOcrImageProvider } from './useOcrImageProvider' const logger = loggerService.withContext('useOcr') -const isProviderAvailable = (provider: ImageOcrProvider | undefined): provider is ImageOcrProvider => +const isProviderAvailable = (provider: OcrProvider | undefined | null): provider is OcrProvider => provider !== undefined export const useOcr = () => { @@ -31,7 +31,7 @@ export const useOcr = () => { providerId: imageProvider.id }) } else { - throw new Error(t('ocr.error.provider.')) + throw new Error(t('ocr.error.provider.not_availabel')) } }, [imageProvider, t] diff --git a/src/renderer/src/i18n/locales/en-us.json b/src/renderer/src/i18n/locales/en-us.json index 783e496696..df349b2880 100644 --- a/src/renderer/src/i18n/locales/en-us.json +++ b/src/renderer/src/i18n/locales/en-us.json @@ -2052,6 +2052,7 @@ "cannot_remove_builtin": "Cannot delete built-in provider", "existing": "The provider already exists", "get_providers": "Failed to get available providers", + "not_availabel": "Provide {{provider}} is not available", "not_found": "OCR provider does not exist", "update_failed": "Failed to update configuration" },