Northern_Lights/cherry-studio
1
0
Fork 0
mirror of https://github.com/CherryHQ/cherry-studio.git synced 2026-01-08 06:19:05 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix: handle undefined html title (#6229)

Browse Source
This commit is contained in:
one 2025-05-20 20:57:14 +08:00 committed by GitHub
parent c468c3cfd5
commit 55c57d72ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/renderer/src/components/CodeBlockView/HtmlArtifacts.tsx
View File

@ -13,7 +13,6 @@ interface Props {
const Artifacts: FC<Props> = ({ html }) => { const Artifacts: FC<Props> = ({ html }) => {
const { t } = useTranslation() const { t } = useTranslation()
const title = extractTitle(html) || 'Artifacts ' + t('chat.artifacts.button.preview')
const { openMinapp } = useMinappPopup() const { openMinapp } = useMinappPopup()
/** /**
@ -23,6 +22,7 @@ const Artifacts: FC<Props> = ({ html }) => {
const path = await window.api.file.create('artifacts-preview.html') const path = await window.api.file.create('artifacts-preview.html')
await window.api.file.write(path, html) await window.api.file.write(path, html)
const filePath = `file://${path}` const filePath = `file://${path}`
const title = extractTitle(html) || 'Artifacts ' + t('chat.artifacts.button.preview')
openMinapp({ openMinapp({
id: 'artifacts-preview', id: 'artifacts-preview',
name: title, name: title,

5
src/renderer/src/utils/__tests__/formats.test.ts
View File

@ -204,6 +204,11 @@ describe('formats', () => {
it('should handle empty string', () => { it('should handle empty string', () => {
expect(extractTitle('')).toBeNull() expect(extractTitle('')).toBeNull()
}) })
it('should handle undefined', () => {
// @ts-ignore for testing
expect(extractTitle(undefined)).toBeNull()
})
}) })
describe('removeSvgEmptyLines', () => { describe('removeSvgEmptyLines', () => {

2
src/renderer/src/utils/formats.ts
View File

@ -54,6 +54,8 @@ $$
} }
export function extractTitle(html: string): string | null { export function extractTitle(html: string): string | null {
if (!html) return null
// 处理标准闭合的标题标签 // 处理标准闭合的标题标签
const titleRegex = /<title>(.*?)<\/title>/i const titleRegex = /<title>(.*?)<\/title>/i
const match = html.match(titleRegex) const match = html.match(titleRegex)