From 6f21844603665342ea82311a85b5284c7295aeb1 Mon Sep 17 00:00:00 2001
From: kangfenmao <kangfenmao@qq.com>
Date: Mon, 13 Jan 2025 09:39:54 +0800
Subject: [PATCH] feat: improved model validation and error handling

---
 .../pages/settings/ProviderSettings/EditModelsPopup.tsx    | 7 +++++--
 .../pages/settings/ProviderSettings/ProviderSetting.tsx    | 4 ++--
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/renderer/src/pages/settings/ProviderSettings/EditModelsPopup.tsx b/src/renderer/src/pages/settings/ProviderSettings/EditModelsPopup.tsx
index decfe24f23..43a1b17b5f 100644
--- a/src/renderer/src/pages/settings/ProviderSettings/EditModelsPopup.tsx
+++ b/src/renderer/src/pages/settings/ProviderSettings/EditModelsPopup.tsx
@@ -68,6 +68,9 @@ const PopupContainer: React.FC<Props> = ({ provider: _provider, resolve }) => {
   }
 
   const onAddModel = (model: Model) => {
+    if (isEmpty(model.name)) {
+      return
+    }
     addModel(model)
   }
 
@@ -92,7 +95,7 @@ const PopupContainer: React.FC<Props> = ({ provider: _provider, resolve }) => {
               description: model?.description,
               owned_by: model?.owned_by
             }))
-            .filter((model) => !isEmpty(model.id))
+            .filter((model) => !isEmpty(model.name))
         )
         setLoading(false)
       } catch (error) {
@@ -151,7 +154,7 @@ const PopupContainer: React.FC<Props> = ({ provider: _provider, resolve }) => {
                 <ListItem key={model.id}>
                   <ListItemHeader>
                     <Avatar src={getModelLogo(model.id)} size={24}>
-                      {model.name[0].toUpperCase()}
+                      {model?.name?.[0]?.toUpperCase()}
                     </Avatar>
                     <ListItemName>
                       <Tooltip title={model.id} placement="top">
diff --git a/src/renderer/src/pages/settings/ProviderSettings/ProviderSetting.tsx b/src/renderer/src/pages/settings/ProviderSettings/ProviderSetting.tsx
index 8aa9043764..c3ab6c33ff 100644
--- a/src/renderer/src/pages/settings/ProviderSettings/ProviderSetting.tsx
+++ b/src/renderer/src/pages/settings/ProviderSettings/ProviderSetting.tsx
@@ -279,9 +279,9 @@ const ProviderSetting: FC<Props> = ({ provider: _provider }) => {
             <ModelListItem key={model.id}>
               <ModelListHeader>
                 <Avatar src={getModelLogo(model.id)} size={22} style={{ marginRight: '8px' }}>
-                  {model.name[0].toUpperCase()}
+                  {model?.name?.[0]?.toUpperCase()}
                 </Avatar>
-                {model.name}
+                {model?.name}
                 <ModelTags model={model} />
                 <Popover content={modelTypeContent(model)} title={t('models.type.select')} trigger="click">
                   <SettingIcon />