From 7a169c424dd5bcc258007a1623004fb2ce7d99ce Mon Sep 17 00:00:00 2001 From: Vaayne Date: Wed, 24 Sep 2025 14:22:59 +0800 Subject: [PATCH] refactor: update logging in message processing to use debug level and improve clarity --- src/main/apiServer/routes/messages.ts | 43 ------------------------- src/main/apiServer/services/messages.ts | 30 ++++++++--------- 2 files changed, 14 insertions(+), 59 deletions(-) diff --git a/src/main/apiServer/routes/messages.ts b/src/main/apiServer/routes/messages.ts index 64775ae304..72433984ac 100644 --- a/src/main/apiServer/routes/messages.ts +++ b/src/main/apiServer/routes/messages.ts @@ -129,15 +129,6 @@ async function processMessageRequest( request.model = modelId } - logger.info('Processing message request:', { - provider: provider.id, - model: request.model, - messageCount: request.messages?.length || 0, - stream: request.stream, - max_tokens: request.max_tokens, - temperature: request.temperature - }) - // Ensure provider is Anthropic type if (provider.type !== 'anthropic') { return res.status(400).json({ @@ -149,12 +140,6 @@ async function processMessageRequest( }) } - logger.info('Provider validation successful:', { - provider: provider.id, - providerType: provider.type, - modelId: request.model - }) - // Validate request const validation = messagesService.validateRequest(request) if (!validation.isValid) { @@ -314,13 +299,6 @@ router.post('/', async (req: Request, res: Response) => { try { const request: MessageCreateParams = req.body - logger.info('Anthropic message request:', { - model: request.model, - messageCount: request.messages?.length || 0, - stream: request.stream, - max_tokens: request.max_tokens - }) - // Validate model ID and get provider const modelValidation = await validateModelId(request.model) if (!modelValidation.valid) { @@ -338,13 +316,6 @@ router.post('/', async (req: Request, res: Response) => { const provider = modelValidation.provider! const modelId = modelValidation.modelId! - logger.info('Model validation successful:', { - provider: provider.id, - providerType: provider.type, - modelId: modelId, - fullModelId: request.model - }) - // Use shared processing function return await processMessageRequest(req, res, provider, modelId) } catch (error: any) { @@ -489,14 +460,6 @@ providerRouter.post('/', async (req: Request, res: Response) => { }) } - logger.info('Provider-specific message request:', { - providerId, - model: request.model, - messageCount: request.messages?.length || 0, - stream: request.stream, - max_tokens: request.max_tokens - }) - // Get provider directly by ID from URL path const provider = await getProviderById(providerId) if (!provider) { @@ -509,12 +472,6 @@ providerRouter.post('/', async (req: Request, res: Response) => { }) } - logger.info('Provider validation successful:', { - provider: provider.id, - providerType: provider.type, - modelId: request.model - }) - // Use shared processing function (no modelId override needed) return await processMessageRequest(req, res, provider) } catch (error: any) { diff --git a/src/main/apiServer/services/messages.ts b/src/main/apiServer/services/messages.ts index e0cef014eb..aebf40e605 100644 --- a/src/main/apiServer/services/messages.ts +++ b/src/main/apiServer/services/messages.ts @@ -46,11 +46,12 @@ export class MessagesService { } async processMessage(request: MessageCreateParams, provider: Provider): Promise { - logger.info('Processing Anthropic message request:', { + logger.debug('Preparing Anthropic message request', { model: request.model, messageCount: request.messages.length, stream: request.stream, - max_tokens: request.max_tokens + maxTokens: request.max_tokens, + provider: provider.id }) // Create Anthropic client for the provider @@ -66,14 +67,12 @@ export class MessagesService { anthropicRequest.system = buildClaudeCodeSystemMessage(request.system || '') } - logger.debug('Sending request to Anthropic provider:', { - provider: provider.id, - apiHost: provider.apiHost - }) - const response = await client.messages.create(anthropicRequest) - logger.info('Successfully processed Anthropic message') + logger.info('Anthropic message completed', { + model: request.model, + provider: provider.id + }) return response } @@ -81,9 +80,10 @@ export class MessagesService { request: MessageCreateParams, provider: Provider ): AsyncIterable { - logger.info('Processing streaming Anthropic message request:', { + logger.debug('Preparing streaming Anthropic message request', { model: request.model, - messageCount: request.messages.length + messageCount: request.messages.length, + provider: provider.id }) // Create Anthropic client for the provider @@ -99,18 +99,16 @@ export class MessagesService { streamingRequest.system = buildClaudeCodeSystemMessage(request.system || '') } - logger.debug('Sending streaming request to Anthropic provider:', { - provider: provider.id, - apiHost: provider.apiHost - }) - const stream = client.messages.stream(streamingRequest) for await (const chunk of stream) { yield chunk } - logger.info('Successfully completed streaming Anthropic message') + logger.info('Completed streaming Anthropic message', { + model: request.model, + provider: provider.id + }) } }