Northern_Lights/cherry-studio
1
0
Fork 0
mirror of https://github.com/CherryHQ/cherry-studio.git synced 2025-12-19 06:30:10 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

refactor: simplify by only converting numbers at parameter layer, not UI layer

Browse Source 
Co-authored-by: DeJeune <67425183+DeJeune@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2025-12-11 08:10:21 +00:00
parent 78f2a4c799
commit 84829f01d2
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/renderer/src/pages/home/Tabs/SettingsTab.tsx
View File

@ -134,19 +134,19 @@ const SettingsTab: FC<Props> = (props) => {
const onTemperatureChange = (value) => {
if (!isNaN(value as number)) {
onUpdateAssistantSettings({ temperature: Number(value) })
onUpdateAssistantSettings({ temperature: value })
}
}
const onContextCountChange = (value) => {
if (!isNaN(value as number)) {
onUpdateAssistantSettings({ contextCount: Number(value) })
onUpdateAssistantSettings({ contextCount: value })
}
}
const onMaxTokensChange = (value) => {
if (!isNaN(value as number)) {
onUpdateAssistantSettings({ maxTokens: Number(value) })
onUpdateAssistantSettings({ maxTokens: value })
}
}

16
src/renderer/src/pages/settings/AssistantSettings/AssistantModelSettings.tsx
View File

@ -52,19 +52,19 @@ const AssistantModelSettings: FC<Props> = ({ assistant, updateAssistant, updateA
const onTemperatureChange = (value) => {
if (!isNaN(value as number)) {
updateAssistantSettings({ temperature: Number(value) })
updateAssistantSettings({ temperature: value })
}
}
const onContextCountChange = (value) => {
if (!isNaN(value as number)) {
updateAssistantSettings({ contextCount: Number(value) })
updateAssistantSettings({ contextCount: value })
}
}
const onTopPChange = (value) => {
if (!isNaN(value as number)) {
updateAssistantSettings({ topP: Number(value) })
updateAssistantSettings({ topP: value })
}
}
@ -114,7 +114,7 @@ const AssistantModelSettings: FC<Props> = ({ assistant, updateAssistant, updateA
<InputNumber
style={{ width: '100%' }}
value={param.value as number}
onChange={(value) => onUpdateCustomParameter(index, 'value', Number(value) || 0)}
onChange={(value) => onUpdateCustomParameter(index, 'value', value || 0)}
step={0.01}
/>
)
@ -278,7 +278,7 @@ const AssistantModelSettings: FC<Props> = ({ assistant, updateAssistant, updateA
onChange={(value) => {
if (!isNull(value)) {
setTemperature(value)
setTimeoutTimer('temperature_onChange', () => updateAssistantSettings({ temperature: Number(value) }), 500)
setTimeoutTimer('temperature_onChange', () => updateAssistantSettings({ temperature: value }), 500)
}
}}
style={{ width: '100%' }}
@ -326,7 +326,7 @@ const AssistantModelSettings: FC<Props> = ({ assistant, updateAssistant, updateA
onChange={(value) => {
if (!isNull(value)) {
setTopP(value)
setTimeoutTimer('topP_onChange', () => updateAssistantSettings({ topP: Number(value) }), 500)
setTimeoutTimer('topP_onChange', () => updateAssistantSettings({ topP: value }), 500)
}
}}
style={{ width: '100%' }}
@ -355,7 +355,7 @@ const AssistantModelSettings: FC<Props> = ({ assistant, updateAssistant, updateA
onChange={(value) => {
if (!isNull(value)) {
setContextCount(value)
setTimeoutTimer('contextCount_onChange', () => updateAssistantSettings({ contextCount: Number(value) }), 500)
setTimeoutTimer('contextCount_onChange', () => updateAssistantSettings({ contextCount: value }), 500)
}
}}
formatter={(value) => (value === MAX_CONTEXT_COUNT ? t('chat.settings.max') : (value ?? ''))}
@ -417,7 +417,7 @@ const AssistantModelSettings: FC<Props> = ({ assistant, updateAssistant, updateA
onChange={(value) => {
if (!isNull(value)) {
setMaxTokens(value)
setTimeoutTimer('maxTokens_onChange', () => updateAssistantSettings({ maxTokens: Number(value) }), 1000)
setTimeoutTimer('maxTokens_onChange', () => updateAssistantSettings({ maxTokens: value }), 1000)
}
}}
style={{ width: '100%' }}

2
src/renderer/src/pages/settings/ModelSettings/DefaultAssistantSettings.tsx
View File

@ -55,7 +55,7 @@ const AssistantSettings: FC = () => {
(setter: Dispatch<SetStateAction<number>>, updater: (value: number) => void) => (value: number | null) => {
if (value !== null) {
setter(value)
updater(Number(value))
updater(value)
}
}
const onTemperatureChange = handleChange(setTemperature, (value) => onUpdateAssistantSettings({ temperature: value }))