Northern_Lights/cherry-studio
1
0
Fork 0
mirror of https://github.com/CherryHQ/cherry-studio.git synced 2026-01-07 22:10:21 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix: shouldn't edit embedding dimension on existing knowledge base (#7022)

Browse Source 
* fix: shouldn't edit embedding dimension on existing knowledge base

* remove dim settings
This commit is contained in:
Wang Jiyuan 2025-06-10 15:34:27 +08:00 committed by GitHub
parent d2147aed3b
commit 90a84bb55a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/renderer/src/pages/knowledge/components/KnowledgeSettingsPopup.tsx
View File

@ -187,32 +187,6 @@ const PopupContainer: React.FC<Props> = ({ base: _base, resolve }) => {
</AdvancedSettingsButton> </AdvancedSettingsButton>
<div style={{ display: showAdvanced ? 'block' : 'none' }}> <div style={{ display: showAdvanced ? 'block' : 'none' }}>
<Form.Item
name="dimensions"
label={t('knowledge.dimensions')}
layout="horizontal"
initialValue={base.dimensions}
tooltip={{ title: t('knowledge.dimensions_size_tooltip') }}
rules={[
{
validator(_, value) {
const maxContext = getEmbeddingMaxContext(base.model.id)
if (value && maxContext && value > maxContext) {
return Promise.reject(
new Error(t('knowledge.dimensions_size_too_large', { max_context: maxContext }))
)
}
return Promise.resolve()
}
}
]}>
<InputNumber
style={{ width: '100%' }}
defaultValue={base.dimensions}
placeholder={t('knowledge.dimensions_size_placeholder')}
disabled={base.model.id !== 'voyage-3-large'}
/>
</Form.Item>
<Form.Item <Form.Item
name="chunkSize" name="chunkSize"
label={t('knowledge.chunk_size')} label={t('knowledge.chunk_size')}

1
src/renderer/src/providers/AiProvider/BaseProvider.ts
View File

@ -56,6 +56,7 @@ export default abstract class BaseProvider {
abstract models(): Promise<OpenAI.Models.Model[]> abstract models(): Promise<OpenAI.Models.Model[]>
abstract generateImage(params: GenerateImageParams): Promise<string[]> abstract generateImage(params: GenerateImageParams): Promise<string[]>
abstract generateImageByChat({ messages, assistant, onChunk, onFilterMessages }: CompletionsParams): Promise<void> abstract generateImageByChat({ messages, assistant, onChunk, onFilterMessages }: CompletionsParams): Promise<void>
// 由于现在出现了一些能够选择嵌入维度的嵌入模型，这个不考虑dimensions参数的方法将只能应用于那些不支持dimensions的模型
abstract getEmbeddingDimensions(model: Model): Promise<number> abstract getEmbeddingDimensions(model: Model): Promise<number>
public abstract convertMcpTools<T>(mcpTools: MCPTool[]): T[] public abstract convertMcpTools<T>(mcpTools: MCPTool[]): T[]
public abstract mcpToolCallResponseToMessage( public abstract mcpToolCallResponseToMessage(