From b50d8b2a23991c19c72335bff1176e58f11d744c Mon Sep 17 00:00:00 2001
From: icarus <eurfelux@gmail.com>
Date: Mon, 20 Oct 2025 03:19:38 +0800
Subject: [PATCH] refactor(ocr): remove unused error message and simplify
 provider check

Move provider availability check outside of useCallback and remove unused error message from translations
---
 src/renderer/src/hooks/ocr/useOcr.ts     | 19 +++++--------------
 src/renderer/src/i18n/locales/en-us.json |  1 -
 2 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/src/renderer/src/hooks/ocr/useOcr.ts b/src/renderer/src/hooks/ocr/useOcr.ts
index f67249ca3c..4c43f9250a 100644
--- a/src/renderer/src/hooks/ocr/useOcr.ts
+++ b/src/renderer/src/hooks/ocr/useOcr.ts
@@ -10,22 +10,13 @@ import { useOcrImageProvider } from './useOcrImageProvider'
 
 const logger = loggerService.withContext('useOcr')
 
+const isProviderAvailable = (provider: ImageOcrProvider | undefined): provider is ImageOcrProvider =>
+  provider !== undefined
+
 export const useOcr = () => {
   const { t } = useTranslation()
   const { imageProvider } = useOcrImageProvider()
 
-  const isProviderAvailable = useCallback(
-    (provider: ImageOcrProvider | undefined): provider is ImageOcrProvider => {
-      if (!provider) {
-        window.toast.error(t('ocr.error.provider.not_found'))
-        return false
-      } else {
-        return true
-      }
-    },
-    [t]
-  )
-
   /**
    * 对图片文件进行OCR识别
    * @param image 图片文件元数据
@@ -38,10 +29,10 @@ export const useOcr = () => {
         logger.debug('ocrImage', { config: imageProvider.config })
         return OcrService.ocr(image, imageProvider)
       } else {
-        throw new Error(t('ocr.error.provider.not_image_provider'))
+        throw new Error(t('ocr.error.provider.'))
       }
     },
-    [imageProvider, isProviderAvailable, t]
+    [imageProvider, t]
   )
 
   /**
diff --git a/src/renderer/src/i18n/locales/en-us.json b/src/renderer/src/i18n/locales/en-us.json
index a8016c0f10..9dbdd32dae 100644
--- a/src/renderer/src/i18n/locales/en-us.json
+++ b/src/renderer/src/i18n/locales/en-us.json
@@ -2053,7 +2053,6 @@
         "existing": "The provider already exists",
         "get_providers": "Failed to get available providers",
         "not_found": "OCR provider does not exist",
-        "not_image_provider": "This provider cannot process image.",
         "update_failed": "Failed to update configuration"
       },
       "unknown": "An error occurred during the OCR process"