From c455b0a70ab78d597707b170f75da2c28b04d492 Mon Sep 17 00:00:00 2001
From: icarus <eurfelux@gmail.com>
Date: Wed, 22 Oct 2025 18:56:29 +0800
Subject: [PATCH] refactor: remove unused setError parameter from mermaid
 components

Clean up code by removing unnecessary setError parameter that was not being used effectively. This simplifies the component interfaces and reduces potential error handling confusion.
---
 src/renderer/src/components/CodeBlockView/view.tsx          | 1 -
 .../src/components/CodeToolbar/hooks/useMermaidFixTool.tsx  | 6 ++----
 src/renderer/src/components/Preview/MermaidPreview.tsx      | 2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/renderer/src/components/CodeBlockView/view.tsx b/src/renderer/src/components/CodeBlockView/view.tsx
index 74a3a06cba..e98cbe2c58 100644
--- a/src/renderer/src/components/CodeBlockView/view.tsx
+++ b/src/renderer/src/components/CodeBlockView/view.tsx
@@ -271,7 +271,6 @@ export const CodeBlockView: React.FC<Props> = memo(({ children: code, language,
       error,
       content: code
     },
-    setError,
     onSave,
     setTools
   })
diff --git a/src/renderer/src/components/CodeToolbar/hooks/useMermaidFixTool.tsx b/src/renderer/src/components/CodeToolbar/hooks/useMermaidFixTool.tsx
index f0ab199a44..9986629459 100644
--- a/src/renderer/src/components/CodeToolbar/hooks/useMermaidFixTool.tsx
+++ b/src/renderer/src/components/CodeToolbar/hooks/useMermaidFixTool.tsx
@@ -26,7 +26,6 @@ interface UseMermaidFixTool {
     content: string
   }
   onSave: (newContent: string) => Promise<void>
-  setError: (error: unknown) => void
   setTools: React.Dispatch<React.SetStateAction<ActionTool[]>>
 }
 
@@ -73,7 +72,7 @@ Example outputs:
 
 `
 
-export const useMermaidFixTool = ({ enabled, context, onSave, setError, setTools }: UseMermaidFixTool) => {
+export const useMermaidFixTool = ({ enabled, context, onSave, setTools }: UseMermaidFixTool) => {
   const { t } = useTranslation()
   const { registerTool, removeTool } = useToolManager(setTools)
   const { language } = useSettings()
@@ -140,7 +139,6 @@ export const useMermaidFixTool = ({ enabled, context, onSave, setError, setTools
         const validResult = parsedResult.data
         if (validResult.fixed) {
           await onSave(validResult.result)
-          setError(undefined)
         } else {
           window.toast.warning({ title: t('code_block.mermaid_fix.failed'), description: validResult.reason })
         }
@@ -153,7 +151,7 @@ export const useMermaidFixTool = ({ enabled, context, onSave, setError, setTools
     }
 
     setPending(blockId, false)
-  }, [setPending, blockId, completion, prompt, t, onSave, setError])
+  }, [setPending, blockId, completion, prompt, t, onSave])
 
   // when unmounted
   useEffect(() => {
diff --git a/src/renderer/src/components/Preview/MermaidPreview.tsx b/src/renderer/src/components/Preview/MermaidPreview.tsx
index 2b7a777139..a1ecd393c5 100644
--- a/src/renderer/src/components/Preview/MermaidPreview.tsx
+++ b/src/renderer/src/components/Preview/MermaidPreview.tsx
@@ -124,7 +124,7 @@ const MermaidPreview = ({
   const error = mermaidError || renderError
 
   useEffect(() => {
-    if (error !== undefined && error !== null && onError !== undefined) {
+    if (onError !== undefined) {
       onError(error)
     }
   }, [error, onError])