From d19dd67213983ed1dc194288d744010dbd99373e Mon Sep 17 00:00:00 2001
From: Wang Jiyuan <59059173+EurFelux@users.noreply.github.com>
Date: Tue, 10 Jun 2025 15:34:27 +0800
Subject: [PATCH] fix: shouldn't edit embedding dimension on existing knowledge
 base (#7022)

* fix: shouldn't edit embedding dimension on existing knowledge base

* remove dim settings
---
 .../components/KnowledgeSettingsPopup.tsx     | 26 -------------------
 .../src/providers/AiProvider/BaseProvider.ts  |  1 +
 2 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/src/renderer/src/pages/knowledge/components/KnowledgeSettingsPopup.tsx b/src/renderer/src/pages/knowledge/components/KnowledgeSettingsPopup.tsx
index 237c4a8bcb..d994fa9ee1 100644
--- a/src/renderer/src/pages/knowledge/components/KnowledgeSettingsPopup.tsx
+++ b/src/renderer/src/pages/knowledge/components/KnowledgeSettingsPopup.tsx
@@ -187,32 +187,6 @@ const PopupContainer: React.FC<Props> = ({ base: _base, resolve }) => {
         </AdvancedSettingsButton>
 
         <div style={{ display: showAdvanced ? 'block' : 'none' }}>
-          <Form.Item
-            name="dimensions"
-            label={t('knowledge.dimensions')}
-            layout="horizontal"
-            initialValue={base.dimensions}
-            tooltip={{ title: t('knowledge.dimensions_size_tooltip') }}
-            rules={[
-              {
-                validator(_, value) {
-                  const maxContext = getEmbeddingMaxContext(base.model.id)
-                  if (value && maxContext && value > maxContext) {
-                    return Promise.reject(
-                      new Error(t('knowledge.dimensions_size_too_large', { max_context: maxContext }))
-                    )
-                  }
-                  return Promise.resolve()
-                }
-              }
-            ]}>
-            <InputNumber
-              style={{ width: '100%' }}
-              defaultValue={base.dimensions}
-              placeholder={t('knowledge.dimensions_size_placeholder')}
-              disabled={base.model.id !== 'voyage-3-large'}
-            />
-          </Form.Item>
           <Form.Item
             name="chunkSize"
             label={t('knowledge.chunk_size')}
diff --git a/src/renderer/src/providers/AiProvider/BaseProvider.ts b/src/renderer/src/providers/AiProvider/BaseProvider.ts
index 48c1e34839..f1beba64d4 100644
--- a/src/renderer/src/providers/AiProvider/BaseProvider.ts
+++ b/src/renderer/src/providers/AiProvider/BaseProvider.ts
@@ -56,6 +56,7 @@ export default abstract class BaseProvider {
   abstract models(): Promise<OpenAI.Models.Model[]>
   abstract generateImage(params: GenerateImageParams): Promise<string[]>
   abstract generateImageByChat({ messages, assistant, onChunk, onFilterMessages }: CompletionsParams): Promise<void>
+  // 由于现在出现了一些能够选择嵌入维度的嵌入模型，这个不考虑dimensions参数的方法将只能应用于那些不支持dimensions的模型
   abstract getEmbeddingDimensions(model: Model): Promise<number>
   public abstract convertMcpTools<T>(mcpTools: MCPTool[]): T[]
   public abstract mcpToolCallResponseToMessage(