Northern_Lights/cherry-studio
1
0
Fork 0
mirror of https://github.com/CherryHQ/cherry-studio.git synced 2026-01-07 13:59:28 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix: update default enableTopP setting to false in AssistantModelSett… (#10754)

Browse Source 
fix: update default enableTopP setting to false in AssistantModelSettings and DefaultAssistantSettings

- Changed default value of enableTopP from true to false in AssistantModelSettings and DefaultAssistantSettings components.
- Updated related logic to ensure consistent behavior across settings.
This commit is contained in:
亢奋猫 2025-10-17 10:36:36 +08:00 committed by GitHub
parent 1c2ce7e0aa
commit dc5bc64040
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/renderer/src/pages/settings/AssistantSettings/AssistantModelSettings.tsx
View File

@ -33,7 +33,7 @@ const AssistantModelSettings: FC<Props> = ({ assistant, updateAssistant, updateA
const [toolUseMode, setToolUseMode] = useState(assistant?.settings?.toolUseMode ?? 'prompt') const [toolUseMode, setToolUseMode] = useState(assistant?.settings?.toolUseMode ?? 'prompt')
const [defaultModel, setDefaultModel] = useState(assistant?.defaultModel) const [defaultModel, setDefaultModel] = useState(assistant?.defaultModel)
const [topP, setTopP] = useState(assistant?.settings?.topP ?? 1) const [topP, setTopP] = useState(assistant?.settings?.topP ?? 1)
const [enableTopP, setEnableTopP] = useState(assistant?.settings?.enableTopP ?? true) const [enableTopP, setEnableTopP] = useState(assistant?.settings?.enableTopP ?? false)
const [customParameters, setCustomParameters] = useState<AssistantSettingCustomParameters[]>( const [customParameters, setCustomParameters] = useState<AssistantSettingCustomParameters[]>(
assistant?.settings?.customParameters ?? [] assistant?.settings?.customParameters ?? []
) )
@ -164,7 +164,7 @@ const AssistantModelSettings: FC<Props> = ({ assistant, updateAssistant, updateA
setMaxTokens(0) setMaxTokens(0)
setStreamOutput(true) setStreamOutput(true)
setTopP(1) setTopP(1)
setEnableTopP(true) setEnableTopP(false)
setCustomParameters([]) setCustomParameters([])
setToolUseMode('prompt') setToolUseMode('prompt')
updateAssistantSettings({ updateAssistantSettings({
@ -175,7 +175,7 @@ const AssistantModelSettings: FC<Props> = ({ assistant, updateAssistant, updateA
maxTokens: 0, maxTokens: 0,
streamOutput: true, streamOutput: true,
topP: 1, topP: 1,
enableTopP: true, enableTopP: false,
customParameters: [], customParameters: [],
toolUseMode: 'prompt' toolUseMode: 'prompt'
}) })

6
src/renderer/src/pages/settings/ModelSettings/DefaultAssistantSettings.tsx
View File

@ -24,7 +24,7 @@ const AssistantSettings: FC = () => {
const [enableMaxTokens, setEnableMaxTokens] = useState(defaultAssistant?.settings?.enableMaxTokens ?? false) const [enableMaxTokens, setEnableMaxTokens] = useState(defaultAssistant?.settings?.enableMaxTokens ?? false)
const [maxTokens, setMaxTokens] = useState(defaultAssistant?.settings?.maxTokens ?? 0) const [maxTokens, setMaxTokens] = useState(defaultAssistant?.settings?.maxTokens ?? 0)
const [topP, setTopP] = useState(defaultAssistant.settings?.topP ?? 1) const [topP, setTopP] = useState(defaultAssistant.settings?.topP ?? 1)
const [enableTopP, setEnableTopP] = useState(defaultAssistant.settings?.enableTopP ?? true) const [enableTopP, setEnableTopP] = useState(defaultAssistant.settings?.enableTopP ?? false)
const [emoji, setEmoji] = useState(defaultAssistant.emoji || getLeadingEmoji(defaultAssistant.name) || '') const [emoji, setEmoji] = useState(defaultAssistant.emoji || getLeadingEmoji(defaultAssistant.name) || '')
const [name, setName] = useState( const [name, setName] = useState(
defaultAssistant.name.replace(getLeadingEmoji(defaultAssistant.name) || '', '').trim() defaultAssistant.name.replace(getLeadingEmoji(defaultAssistant.name) || '', '').trim()
@ -71,7 +71,7 @@ const AssistantSettings: FC = () => {
setEnableMaxTokens(false) setEnableMaxTokens(false)
setMaxTokens(0) setMaxTokens(0)
setTopP(1) setTopP(1)
setEnableTopP(true) setEnableTopP(false)
updateDefaultAssistant({ updateDefaultAssistant({
...defaultAssistant, ...defaultAssistant,
settings: { settings: {
@ -83,7 +83,7 @@ const AssistantSettings: FC = () => {
maxTokens: DEFAULT_MAX_TOKENS, maxTokens: DEFAULT_MAX_TOKENS,
streamOutput: true, streamOutput: true,
topP: 1, topP: 1,
enableTopP: true enableTopP: false
} }
}) })
} }

4
src/renderer/src/services/AssistantService.ts
View File

@ -35,7 +35,7 @@ export const DEFAULT_ASSISTANT_SETTINGS: AssistantSettings = {
maxTokens: 0, maxTokens: 0,
streamOutput: true, streamOutput: true,
topP: 1, topP: 1,
enableTopP: true, enableTopP: false,
toolUseMode: 'prompt', toolUseMode: 'prompt',
customParameters: [] customParameters: []
} }
@ -169,7 +169,7 @@ export const getAssistantSettings = (assistant: Assistant): AssistantSettings =>
temperature: assistant?.settings?.temperature ?? DEFAULT_TEMPERATURE, temperature: assistant?.settings?.temperature ?? DEFAULT_TEMPERATURE,
enableTemperature: assistant?.settings?.enableTemperature ?? true, enableTemperature: assistant?.settings?.enableTemperature ?? true,
topP: assistant?.settings?.topP ?? 1, topP: assistant?.settings?.topP ?? 1,
enableTopP: assistant?.settings?.enableTopP ?? true, enableTopP: assistant?.settings?.enableTopP ?? false,
enableMaxTokens: assistant?.settings?.enableMaxTokens ?? false, enableMaxTokens: assistant?.settings?.enableMaxTokens ?? false,
maxTokens: getAssistantMaxTokens(), maxTokens: getAssistantMaxTokens(),
streamOutput: assistant?.settings?.streamOutput ?? true, streamOutput: assistant?.settings?.streamOutput ?? true,