From eb4927260a08da4830f491f1f3432789fc6d0e88 Mon Sep 17 00:00:00 2001
From: icarus <eurfelux@gmail.com>
Date: Mon, 20 Oct 2025 08:10:14 +0800
Subject: [PATCH] refactor(OcrImageSettings): remove logger and optimize
 setImageProvider

Replace direct logger usage with commented code and wrap setImageProvider in useCallback
---
 .../DocProcessSettings/OcrImageSettings.tsx   | 23 ++++++++-----------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/src/renderer/src/pages/settings/DocProcessSettings/OcrImageSettings.tsx b/src/renderer/src/pages/settings/DocProcessSettings/OcrImageSettings.tsx
index 2a2852d786..bd953ec214 100644
--- a/src/renderer/src/pages/settings/DocProcessSettings/OcrImageSettings.tsx
+++ b/src/renderer/src/pages/settings/DocProcessSettings/OcrImageSettings.tsx
@@ -1,6 +1,5 @@
 import { Skeleton } from '@cherrystudio/ui'
 import { Alert } from '@heroui/react'
-import { loggerService } from '@logger'
 import { ErrorTag } from '@renderer/components/Tags/ErrorTag'
 import { isMac, isWin } from '@renderer/config/constant'
 import { useOcrImageProvider } from '@renderer/hooks/ocr/useOcrImageProvider'
@@ -8,12 +7,12 @@ import { useOcrProviders } from '@renderer/hooks/ocr/useOcrProviders'
 import { BuiltinOcrProviderIdMap, isImageOcrProvider } from '@renderer/types'
 import { getErrorMessage } from '@renderer/utils'
 import { Select } from 'antd'
-import { useMemo } from 'react'
+import { useCallback, useMemo } from 'react'
 import { useTranslation } from 'react-i18next'
 
 import { SettingRow, SettingRowTitle } from '..'
 
-const logger = loggerService.withContext('OcrImageSettings')
+// const logger = loggerService.withContext('OcrImageSettings')
 
 const OcrImageSettings = () => {
   const { t } = useTranslation()
@@ -22,16 +21,12 @@ const OcrImageSettings = () => {
 
   const imageProviders = useMemo(() => providers?.filter((p) => isImageOcrProvider(p)) ?? [], [providers])
 
-  const setImageProvider = (id: string) => {
-    const provider = imageProviders.find((p) => p.id === id)
-    if (!provider) {
-      logger.error(`Failed to find image provider by id: ${id}`)
-      window.toast.error(t('settings.tool.ocr.image.error.provider_not_found'))
-      return
-    }
-
-    setImageProviderId(id)
-  }
+  const setImageProvider = useCallback(
+    (id: string) => {
+      setImageProviderId(id)
+    },
+    [setImageProviderId]
+  )
 
   const platformSupport = isMac || isWin
   const options = useMemo(() => {
@@ -78,7 +73,7 @@ const OcrImageSettings = () => {
         )}
       </>
     )
-  }, [])
+  }, [error, imageProvider, imageProviderId, isSystem, loading, options, platformSupport, setImageProvider, t])
 
   return (
     <>