From f4a6dd91cfef108a996f41631084be198f1e6b77 Mon Sep 17 00:00:00 2001
From: icarus <eurfelux@gmail.com>
Date: Tue, 14 Oct 2025 16:16:46 +0800
Subject: [PATCH] fix(ocr): move ProviderSettings component outside main
 component

Extract ProviderSettings component to fix react-hooks error
---
 .../OcrProviderSettings.tsx                   | 36 +++++++++----------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/src/renderer/src/pages/settings/DocProcessSettings/OcrProviderSettings.tsx b/src/renderer/src/pages/settings/DocProcessSettings/OcrProviderSettings.tsx
index 120e5a9e48..911bd651b2 100644
--- a/src/renderer/src/pages/settings/DocProcessSettings/OcrProviderSettings.tsx
+++ b/src/renderer/src/pages/settings/DocProcessSettings/OcrProviderSettings.tsx
@@ -26,23 +26,6 @@ const OcrProviderSettings = ({ provider }: Props) => {
     return null
   }
 
-  const ProviderSettings = () => {
-    if (isBuiltinOcrProvider(provider)) {
-      switch (provider.id) {
-        case 'tesseract':
-          return <OcrTesseractSettings />
-        case 'system':
-          return <OcrSystemSettings />
-        case 'paddleocr':
-          return <OcrPpocrSettings />
-        default:
-          return null
-      }
-    } else {
-      throw new Error('Not supported OCR provider')
-    }
-  }
-
   return (
     <SettingGroup theme={themeMode}>
       <SettingTitle>
@@ -53,7 +36,7 @@ const OcrProviderSettings = ({ provider }: Props) => {
       </SettingTitle>
       <Divider style={{ width: '100%', margin: '10px 0' }} />
       <ErrorBoundary>
-        <ProviderSettings />
+        <ProviderSettings provider={provider} />
       </ErrorBoundary>
     </SettingGroup>
   )
@@ -64,4 +47,21 @@ const ProviderName = styled.span`
   font-weight: 500;
 `
 
+const ProviderSettings = ({ provider }: { provider: OcrProvider }) => {
+  if (isBuiltinOcrProvider(provider)) {
+    switch (provider.id) {
+      case 'tesseract':
+        return <OcrTesseractSettings />
+      case 'system':
+        return <OcrSystemSettings />
+      case 'paddleocr':
+        return <OcrPpocrSettings />
+      default:
+        return null
+    }
+  } else {
+    throw new Error('Not supported OCR provider')
+  }
+}
+
 export default OcrProviderSettings