From f5f542911f91267bb81d2bcff6c9d640366725a4 Mon Sep 17 00:00:00 2001
From: icarus <eurfelux@gmail.com>
Date: Thu, 18 Sep 2025 21:43:06 +0800
Subject: [PATCH] feat(sessions): add CreateSessionResponse type for better
 type safety

Introduce CreateSessionResponse type and schema to clearly define the return type of session creation operations. This improves type safety and consistency across the codebase when handling session responses.
---
 src/main/apiServer/routes/agents/handlers/sessions.ts | 3 ++-
 src/main/services/agents/services/SessionService.ts   | 3 ++-
 src/renderer/src/types/agent.ts                       | 4 ++++
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/main/apiServer/routes/agents/handlers/sessions.ts b/src/main/apiServer/routes/agents/handlers/sessions.ts
index c933c0242e..2243c5a2bb 100644
--- a/src/main/apiServer/routes/agents/handlers/sessions.ts
+++ b/src/main/apiServer/routes/agents/handlers/sessions.ts
@@ -1,5 +1,6 @@
 import { loggerService } from '@logger'
 import { sessionMessageService, sessionService } from '@main/services/agents'
+import { CreateSessionResponse } from '@types'
 import { Request, Response } from 'express'
 
 const logger = loggerService.withContext('ApiServerSessionsHandlers')
@@ -12,7 +13,7 @@ export const createSession = async (req: Request, res: Response): Promise<Respon
     logger.info(`Creating new session for agent: ${agentId}`)
     logger.debug('Session data:', sessionData)
 
-    const session = await sessionService.createSession(agentId, sessionData)
+    const session = (await sessionService.createSession(agentId, sessionData)) satisfies CreateSessionResponse
 
     logger.info(`Session created successfully: ${session.id}`)
     return res.status(201).json(session)
diff --git a/src/main/services/agents/services/SessionService.ts b/src/main/services/agents/services/SessionService.ts
index 39f73f52fd..1141a26014 100644
--- a/src/main/services/agents/services/SessionService.ts
+++ b/src/main/services/agents/services/SessionService.ts
@@ -2,6 +2,7 @@ import type {
   AgentEntity,
   AgentSessionEntity,
   CreateSessionRequest,
+  CreateSessionResponse,
   GetAgentSessionResponse,
   ListOptions,
   UpdateSessionRequest
@@ -25,7 +26,7 @@ export class SessionService extends BaseService {
     await BaseService.initialize()
   }
 
-  async createSession(agentId: string, req: CreateSessionRequest): Promise<AgentSessionEntity> {
+  async createSession(agentId: string, req: CreateSessionRequest): Promise<CreateSessionResponse> {
     this.ensureInitialized()
 
     // Validate agent exists - we'll need to import AgentService for this check
diff --git a/src/renderer/src/types/agent.ts b/src/renderer/src/types/agent.ts
index 9ffc288c31..404d767b23 100644
--- a/src/renderer/src/types/agent.ts
+++ b/src/renderer/src/types/agent.ts
@@ -186,6 +186,10 @@ export interface CreateSessionMessageRequest {
   content: string
 }
 
+export const CreateSessionResponseSchema = AgentSessionEntitySchema
+
+export type CreateSessionResponse = AgentSessionEntity
+
 export const AgentServerErrorSchema = z.object({
   message: z.string(),
   type: z.string(),