Northern_Lights/cherry-studio
1
0
Fork 0
mirror of https://github.com/CherryHQ/cherry-studio.git synced 2025-12-25 11:20:07 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

refactor(OcrImageSettings): remove logger and optimize setImageProvider

Browse Source 
Replace direct logger usage with commented code and wrap setImageProvider in useCallback
This commit is contained in:
icarus 2025-10-20 08:10:14 +08:00
parent a2e628d7e9
commit eb4927260a
1 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/renderer/src/pages/settings/DocProcessSettings/OcrImageSettings.tsx
View File

@ -1,6 +1,5 @@
import { Skeleton } from '@cherrystudio/ui'
import { Alert } from '@heroui/react'
import { loggerService } from '@logger'
import { ErrorTag } from '@renderer/components/Tags/ErrorTag'
import { isMac, isWin } from '@renderer/config/constant'
import { useOcrImageProvider } from '@renderer/hooks/ocr/useOcrImageProvider'
@ -8,12 +7,12 @@ import { useOcrProviders } from '@renderer/hooks/ocr/useOcrProviders'
import { BuiltinOcrProviderIdMap, isImageOcrProvider } from '@renderer/types'
import { getErrorMessage } from '@renderer/utils'
import { Select } from 'antd'
import { useMemo } from 'react'
import { useCallback, useMemo } from 'react'
import { useTranslation } from 'react-i18next'
import { SettingRow, SettingRowTitle } from '..'
const logger = loggerService.withContext('OcrImageSettings')
// const logger = loggerService.withContext('OcrImageSettings')
const OcrImageSettings = () => {
const { t } = useTranslation()
@ -22,16 +21,12 @@ const OcrImageSettings = () => {
const imageProviders = useMemo(() => providers?.filter((p) => isImageOcrProvider(p)) ?? [], [providers])
const setImageProvider = (id: string) => {
const provider = imageProviders.find((p) => p.id === id)
if (!provider) {
logger.error(`Failed to find image provider by id: ${id}`)
window.toast.error(t('settings.tool.ocr.image.error.provider_not_found'))
return
}
setImageProviderId(id)
}
const setImageProvider = useCallback(
(id: string) => {
setImageProviderId(id)
},
[setImageProviderId]
)
const platformSupport = isMac || isWin
const options = useMemo(() => {
@ -78,7 +73,7 @@ const OcrImageSettings = () => {
)}
</>
)
}, [])
}, [error, imageProvider, imageProviderId, isSystem, loading, options, platformSupport, setImageProvider, t])
return (
<>